Unify build workflows - #16096
Merged
Brett Cannon (brettcannon) merged 8 commits intoMay 3, 2021
Merged
Conversation
github-actions
Bot
requested review from
Kartik Raj (karrtikr) and
Paula (paulacamargo25)
April 29, 2021 23:10
| NODE_VERSION: 12.15.0 | ||
| PYTHON_VERSION: 3.9 | ||
| MOCHA_REPORTER_JUNIT: true # Use the mocha-multi-reporters and send output to both console (spec) and JUnit (mocha-junit-reporter). Also enables a reporter which exits the process running the tests if it haven't already. |
There was a problem hiding this comment.
MOCHA_REPORTER_JUNIT enables a reporter which exits the process running the tests if it haven't already. It had been observed that even though all the tests pass, for some reason the action did not exit and got stuck. I think we should restore it. Brett Cannon (@brettcannon)
Member
Author
There was a problem hiding this comment.
https://github.com/microsoft/vscode-python/blob/main/.github/workflows/build.yml
Also feel free to open a PR for this sort of thing. I also left it out since it was false in 'release' but true in 'insiders'. I have just made it true regardless of what build is occurring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.